Added new constructor for GraphServiceClient #2388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@baywet @andrueastman can you have a look at this PR |
baywet
requested changes
Jun 5, 2025
src/main/java/com/microsoft/graph/serviceclient/GraphServiceClient.java
Outdated
Show resolved
Hide resolved
baywet
previously approved these changes
Jun 5, 2025
Member
baywet
left a comment
baywet
left a comment
There was a problem hiding this comment.
Thank you for making the changes!
Would you mind replicating the change in beta please?
Contributor
Author
Member
|
@raghucha thanks for putting the beta PR together. As you can see the CI is failing, I think this is due to a missing import. Can you correct the issue please? |
missing import
auto-merge was automatically disabled
June 5, 2025 19:43
Head branch was pushed to by a user without write access
baywet
previously approved these changes
Jun 5, 2025
Member
baywet
left a comment
baywet
left a comment
There was a problem hiding this comment.
Thank you for making the changes!
peombwa
reviewed
Jun 6, 2025
auto-merge was automatically disabled
June 9, 2025 13:10
Head branch was pushed to by a user without write access
baywet
requested changes
Jun 9, 2025
src/main/java/com/microsoft/graph/serviceclient/GraphServiceClient.java
Outdated
Show resolved
Hide resolved
baywet
approved these changes
Jun 9, 2025
Member
baywet
left a comment
baywet
left a comment
There was a problem hiding this comment.
Thank you for making the changes!
Could you replicate the changes in beta please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2354
Fixes [#]2354(#2354)
-Allows Us to Overide the default Base URL in use cases such as GCC customers